"UPDATE table_name SET w = $1, x = $2, z = $4 WHERE y = $3 RETURNING *",

does not do the same as

"UPDATE table_name SET w = $1, x = $2, y = $3, z = $4 RETURNING *",

It's 2 am and my mind blanked out the WHERE, and just wanted the numbers neatly in order of 1234.

idiot.

FML.

  • drekly@lemmy.worldOP
    link
    fedilink
    English
    arrow-up
    2
    ·
    1 year ago

    Thanks, I'll look into it! I'm interested in why you got downvoted though! 😅

    • jjjalljs@ttrpg.network
      link
      fedilink
      arrow-up
      3
      ·
      1 year ago

      I didn't downvote but some people like ideologically dislike orms. The reasons I've heard are usually "I can write better SQL by hand", "I don't want to use/learn another library", "it has some limitations"

      Those things can be true. Writing better SQL by hand definitely is a big "it depends", though.

      • max@feddit.nl
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        I can see why people might dislike them. Adds some bloat perhaps. But at the same time, I like the idea that my input is definitely sanitised since the ORM was written by people who know what they’re doing. That’s not to say it won’t have any vulnerabilities at all, but the chance of them existing is a lot lower than when I write the queries by hand. A lapse of judgement is all it takes. Even more relevant for beginning developers who might not be aware of such vulnerabilities existing.

        • drekly@lemmy.worldOP
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 year ago

          For a personal tool that runs locally I can handle some bloat in the name of safety!

          • max@feddit.nl
            link
            fedilink
            arrow-up
            1
            ·
            1 year ago

            Mostly just safety from yourself/your own little errors in input, but it can’t hurt for sure! Input sanitation is mostly relevant to fend off script kiddies. Relevant xkcd

    • max@feddit.nl
      link
      fedilink
      arrow-up
      2
      ·
      edit-2
      1 year ago

      Short story, haters gonna hate ¯\_(ツ)_/¯ Long story, see my comment to the commenter below you. :)